Fix the Seyan spell power rounding

Botar · Post by **Botar** » Sun Aug 14, 2016 4:14 pm

My suggestion is to fix the Seyan spell power rounding, like the topic says

Even with the rebirth spell power bonus I'm not getting the last point of spell power on my spells. This is a problem, especially on bless, where the difference between power 299 and power 300 is a point of bwias.

I know I brought it up before and it was blamed on a rounding error, but is there any way this can get fixed?

Botar · Post by **Botar** » Sun Aug 14, 2016 4:29 pm

Looks like it isn't just a seyan issue, Cicgurnm has 203 mod on his necro with a .95 spell modifier and gets power 191

203*.95=192.85 so it rounds down to 192, then it just takes a point off for who knows what reason

Asmodeus · Post by **Asmodeus** » Sun Aug 14, 2016 4:35 pm

lol too OP already!

Botar · Post by **Botar** » Sun Aug 14, 2016 4:43 pm

Tested it on my hara, doesn't happen to him. I guess you need a spell power bonus to get the full benefit of your spells

Asmodeus · Post by **Asmodeus** » Sun Aug 14, 2016 4:51 pm

You should be at 0% now aren't you?

Botar · Post by **Botar** » Sun Aug 14, 2016 4:55 pm

My seyan is at 0% now, yes. Still gets a point subtracted for some reason.

Lurker · Post by **Lurker** » Mon Sep 19, 2016 7:06 pm

I think it is working as intened. The rebirth is a 5% increase 5% increase of .95 is .9975 not 1.

Motoko · Post by **Motoko** » Mon Sep 19, 2016 7:43 pm

Lurker wrote:I think it is working as intened. The rebirth is a 5% increase 5% increase of .95 is .9975 not 1.

Correct, it's multiplicative.

Post by **LazyWarrior** » Mon Sep 19, 2016 7:58 pm

Motoko wrote:
Lurker wrote:I think it is working as intened. The rebirth is a 5% increase 5% increase of .95 is .9975 not 1.
Correct, it's multiplicative.

I'm pretty sure its not(if it is it rounds up for every other race so it doesn't matter), only seyan and necro have this issue, and they have this issue with or without rebirth I'm pretty sure.

Motoko · Post by **Motoko** » Mon Sep 19, 2016 8:41 pm

LazyWarrior wrote:
Motoko wrote:
Lurker wrote:I think it is working as intened. The rebirth is a 5% increase 5% increase of .95 is .9975 not 1.
Correct, it's multiplicative.
I'm pretty sure its not(if it is it rounds up for every other race so it doesn't matter), only seyan and necro have this issue, and they have this issue with or without rebirth I'm pretty sure.

If it's not it needs to be fixed to be because that's what was agreed.

IE Sorc should be 1.1* 1.05, not 1.1+0.05

Post by **LazyWarrior** » Mon Sep 19, 2016 8:44 pm

Motoko wrote:
LazyWarrior wrote:
Motoko wrote: Correct, it's multiplicative.
I'm pretty sure its not(if it is it rounds up for every other race so it doesn't matter), only seyan and necro have this issue, and they have this issue with or without rebirth I'm pretty sure.
If it's not it needs to be fixed to be because that's what was agreed.

IE Sorc should be 1.1* 1.05, not 1.1+0.05

What I'm saying is, this isn't related to rebirth. Its just an issue with seyans and necros.

Lurker · Post by **Lurker** » Tue Sep 20, 2016 3:09 pm

There is no rounding happening. The values in the code are done as ints. Literally any decimals just don't exist. If the result is 100.99999(if you were multiplying floats) all the code knows is 100. I just checked and verified seyans get a proper .95 and talked to a rebirth seyan and necro and they get .995. Sorcs get a 1.10 with no rounding happening as well, because like said when you just assign a float to an int the decimals are just done away with unless explicity running a function that rounds, which, unless LL has added, it doesn't do.

Lurker · Post by **Lurker** » Tue Sep 20, 2016 4:08 pm

Okay I talked to lazy in game I understand what he is saying now. I don't think it's a rounding issue but a simple floating point math sucks issue. Definitely fixable not sure how serious of a deal it is but I'd be willing to submit the code if it would be accepted.